Remove not needed google-cloud dependency (see #328) and correct GCP … #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…platform release string. Signed-off-by: Stuart Paterson <spaterson@chef.io>
|
This is a pretty critical update for us in chef/chef-dk land. We fixed up a dep that was holding back inspec 2.2 and now we're getting this massive new set of deps. If we can get this merged an a new version of train pushed up it'd be great. I'd like to get the latest inspec up in DK. |
tyler-ball
added a commit
to chef/chef-apply
that referenced
this pull request
Jul 31, 2018
All the google-* deps will be removed soon via inspec/train#329 I got rid of the 'localdev' group because having those gems in the lock was causing issues with running the ChefDK tests. We can add them back later if we want. Signed-off-by: tyler-ball <tball@chef.io>
4 tasks
tyler-ball
added a commit
to chef/chef-apply
that referenced
this pull request
Jul 31, 2018
All the google-* deps will be removed soon via inspec/train#329 I got rid of the 'localdev' group because having those gems in the lock was causing issues with running the ChefDK tests. We can add them back later if we want. Signed-off-by: tyler-ball <tball@chef.io>
|
Thanks @skpaterson @jquick This unblocks the ChefDK release |
|
💯 this would cleanup a lot of inspec-deps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…platform release string.
Signed-off-by: Stuart Paterson spaterson@chef.io